Skip to content

Conversation

Akuukis
Copy link
Contributor

@Akuukis Akuukis commented Sep 30, 2025

👀 Preview steps

In short, nothing changes.

  1. ℹ️ go to http://kf.kobo.local/#/account/security
  2. have 10+ access log entries
  3. 🟢 notice that pagination loads fresh data nicely while placeholding old data in background
  4. 🟢 notice that exporting access logs still works

@Akuukis Akuukis self-assigned this Sep 30, 2025
@Akuukis Akuukis force-pushed the kalvis/api-orval-access-logs branch from 238b275 to 12e60a3 Compare September 30, 2025 09:50
@noliveleger noliveleger removed their request for review September 30, 2025 13:17
Copy link
Member

@magicznyleszek magicznyleszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is clean and nice, I found one issue though

@magicznyleszek magicznyleszek self-requested a review October 2, 2025 15:40
@Akuukis Akuukis force-pushed the kalvis/api-orval-access-logs branch from 12e60a3 to 68f2e44 Compare October 15, 2025 10:24
@Akuukis Akuukis force-pushed the kalvis/api-orval-access-logs branch from 68f2e44 to d349f99 Compare October 15, 2025 10:25
@Akuukis Akuukis merged commit 831ab0d into main Oct 15, 2025
11 checks passed
@Akuukis Akuukis deleted the kalvis/api-orval-access-logs branch October 15, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants